Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Replace spyc yaml parser #772

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[TASK] Replace spyc yaml parser #772

merged 1 commit into from
Apr 8, 2024

Conversation

DavidBruchmann
Copy link
Contributor

fix #755

@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation maintenance labels Apr 5, 2024
@PKuhlmay PKuhlmay changed the base branch from master to typo3-12-reactjs April 5, 2024 06:31
@github-actions github-actions bot removed bug Something isn't working documentation Improvements or additions to documentation labels Apr 5, 2024
@PKuhlmay
Copy link
Collaborator

PKuhlmay commented Apr 5, 2024 •
edited
Loading

I rebased it and pushed it again.

I still need to test this.

@PKuhlmay PKuhlmay self-requested a review April 5, 2024 12:29
@PKuhlmay PKuhlmay added this to the Next v12 Release milestone Apr 5, 2024
@DavidBruchmann
Copy link
Contributor Author

DavidBruchmann commented Apr 5, 2024 •
edited
Loading

Thanks, the change in Build/Sources/components/ReactFlow/CustomModelNode.jsx is not desired, it's a step backwards.

@DavidBruchmann
Copy link
Contributor Author

there is still more, you reverted several commits from me.
In 5d129d2 is more old code.

@PKuhlmay
Copy link
Collaborator

PKuhlmay commented Apr 5, 2024

I need to investigate this a little bit more.

The Symfony Parser sets some objects to null, the old one set it to an empty string.

I am not sure at the moment if this leads to problems but I need to check this at first.

Old one:
Bildschirmfoto 2024-04-05 um 20 44 29

New one:
Bildschirmfoto 2024-04-05 um 14 56 05

@PKuhlmay PKuhlmay merged commit 99bdea6 into FriendsOfTYPO3:typo3-12-reactjs Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKuhlmay PKuhlmay Awaiting requested review from PKuhlmay

Assignees
No one assigned
Labels
maintenance needs testing TYPO3 12
Projects
None yet
Milestone
Next v12 Release
Development

Successfully merging this pull request may close these issues.

Remove SpycYAMLParser
2 participants
@DavidBruchmann @PKuhlmay